fix clippy errors in 1.60 #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 190 190
Lines 54754 54754
=======================================
Hits 45310 45310
Misses 9444 9444
Continue to review full report at Codecov.
|
|
Do we need a follow-on PR to really fix the lints? |
that would be a good idea @HaoYang670 . Thank you The |
|
The |
MazterQyou
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Jul 13, 2022
MazterQyou
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 4, 2022
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 26, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 27, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Sep 5, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Sep 5, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Rust 1.60 is released 🎉
Clippy has added some new lints which were failing on CI
Changes
"Fix" lints (by telling clippy to ignore them) to get CI clean